Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inky] Add Inky Impression 7.3" support #75

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fstanis
Copy link

@fstanis fstanis commented Sep 28, 2024

Inky Impression 7.3" is a larger e-ink display that unlike smaller variants is based on AC073TC1A rather than UC8159.

This PR is effectively a port of pimoroni/inky#158 since the difference is primarily in the reset and update commads.

(draft until I have a chance to properly test)

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes missing coverage. Please review.

Project coverage is 45.8%. Comparing base (2cf8fa1) to head (2a24918).

Files with missing lines Patch % Lines
inky/impression.go 0.0% 136 Missing ⚠️
inky/types.go 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main     #75     +/-   ##
=======================================
- Coverage   46.4%   45.8%   -0.6%     
=======================================
  Files         82      82             
  Lines      10031   10157    +126     
=======================================
- Hits        4658    4654      -4     
- Misses      5211    5339    +128     
- Partials     162     164      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maruel
Copy link
Member

maruel commented Dec 7, 2024

I just saw the PR as it is a draft. Can you fix the linter errors? You'll need to rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants