Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Akka.NET 1.1 #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update for Akka.NET 1.1 #198

wants to merge 1 commit into from

Conversation

FOstyn
Copy link

@FOstyn FOstyn commented Oct 21, 2016

No description provided.

@FOstyn FOstyn closed this Oct 21, 2016
@FOstyn FOstyn reopened this Oct 21, 2016
Aaronontheweb
Aaronontheweb reviewed Oct 21, 2016
View reviewed changes
src/Unit-1/DoThis/WinTail.csproj
</Reference>
<Reference Include="System" />
<Reference Include="System.Collections.Immutable, Version=1.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Akka.NET does not use System.Collections.Immutable 1.2 due to MSFT breaking SemVer on 1.1.37. Please install 1.1.36

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea if this has been fixed in the 1.3.x version of System.Collections.Immutable?

src/Unit-1/DoThis/packages.config
<package id="Newtonsoft.Json" version="6.0.8" targetFramework="net45" />
<package id="Akka" version="1.1.1" targetFramework="net45" />
<package id="Newtonsoft.Json" version="9.0.1" targetFramework="net45" />
<package id="System.Collections.Immutable" version="1.2.0" targetFramework="net45" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading this! Looks like I forgot to do this earlier, but please see previous comment about version of System.Collections.Immutable

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dknoodle dknoodle dknoodle left review comments

@Aaronontheweb Aaronontheweb Aaronontheweb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FOstyn @CLAassistant @Aaronontheweb @dknoodle