Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom fields not being removed on app uninstallation (#278) #279

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix custom fields not being removed on app uninstallation (#278) #279

wants to merge 1 commit into from

Conversation

Mathan-V
Copy link

@Mathan-V Mathan-V commented Oct 9, 2024 •
edited
Loading

Purpose

This document outlines the changes made to ensure that custom fields are properly removed during the uninstallation of the app.

Issue Overview

When the app is uninstalled, certain custom fields remain in the system, leading to errors during site migration. This pull request addresses that issue.

Changes Made

  1. Uninstall Script Update:

    • Enhanced the uninstall script to ensure that all custom fields associated with the app are removed.
    • Added logic to check for any references or dependencies on these custom fields within other DocTypes.

  2. Testing Improvements:

    • Conducted thorough tests to confirm that the uninstallation process is effective and clean.
    • Ensured that migrating the site afterward does not result in any errors related to the removed custom fields.

Impact

  • This change will prevent errors during site migrations after the app is uninstalled.
  • It enhances the overall reliability of the app's uninstallation process.

Testing Procedures

  • Steps taken to validate the changes:
    • Uninstall the app in a controlled environment.
    • Check the database for any remaining custom fields.
    • Attempt to migrate the site and confirm that no errors are thrown related to the custom fields.

Documentation

  • Updated any relevant documentation to reflect the changes made in the uninstall process.

Acknowledgement

Conclusion

These changes ensure that the app behaves as expected upon uninstallation, providing a smoother experience for users migrating their sites.

@Mathan-V
Fix: Resolve persistent custom fields issue post-uninstallation
8f9bdc3 
- Addressed the problem where custom fields remain after app uninstallation and site migration.
- Implemented cleanup logic to ensure all custom fields are removed during the uninstallation process.
- Added migration scripts to identify and delete lingering custom fields across all relevant DocTypes.
- Updated documentation to reflect changes in uninstallation procedures.
@Mathan-V Mathan-V changed the base branch from develop to version-15 October 9, 2024 05:45
@Mathan-V Mathan-V changed the base branch from version-15 to develop October 9, 2024 06:46
@Mathan-V Mathan-V mentioned this pull request Oct 9, 2024
Open
vishwaravi321
vishwaravi321 suggested changes Oct 10, 2024
View reviewed changes
Copy link

@vishwaravi321 vishwaravi321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments, doc strings for better clarity and collaborations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwaravi321 vishwaravi321 vishwaravi321 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mathan-V @vishwaravi321