Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes testing on R v3, and adds testing R devel #284

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Removes testing on R v3, and adds testing R devel #284

merged 2 commits into from
Jul 8, 2024

Conversation

hlapp
Copy link
Member

@hlapp hlapp commented Jul 8, 2024

Fixes #283.

@hlapp
Copy link
Member Author

hlapp commented Jul 8, 2024

The question is whether we should also explicitly raise the R version requirement in DESCRIPTION to 4.x. In theory this would sounds like a trivial change, but I think this should nonetheless precipitate incrementing the version to 0.4.x. Otherwise, if incremented only to 0.3.1, it would signal that an automatic upgrade from 0.3.0 is OK when in reality it would break things in an R 3.x environment. Or perhaps it simply wouldn't get upgraded in that environment?

@johnbradley any thoughts either way?

@hlapp hlapp requested a review from johnbradley July 8, 2024 00:45
@johnbradley
Copy link
Contributor

I would raise the R version to 4.0. If our R3 tests failed to install dependencies something similar might happen to a user with R 3 installed. I would expect existing R3 installations to not install the new version of rphenoscape once we raise the R requirement to 4. Going with 0.4.x for our version to convey the bigger jump also sounds good since we aren't at 1.0.x yet.

@hlapp
Copy link
Member Author

hlapp commented Jul 8, 2024

OK. I upgraded the required R version. I'll increment the version later once we perhaps fold a few more clean-ups into the upgrade (such as #285, and the checks also indicate some URLs that need fixing).

Copy link
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlapp hlapp merged commit 100a89c into master Jul 8, 2024
2 checks passed
@hlapp hlapp temporarily deployed to github-pages July 8, 2024 14:16 — with GitHub Pages Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some dependencies have become unavailable for R 3.x
2 participants