Fixed tests and added build task to all branches in circleci #515
+21
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #514
Developer Checklist (Definition of Done)
release: minor
) to this PR following semverSummary of changes
phovea_[core|clue|...]
repos a long time ago, or the existance of the/dist/tsBuildInfoFile
.build-only
job to run in all branches, that's how this was missed in the first place. @anita-steiner was it intended to not be run in any branches? If yes I can remove it, but I think we should keep it right?You don't seem to have a generator with the name “phovea:_check-own-version” installed.
. I can't really put my finger on the reason, but it might be due to the way tests are run/the testrunner resolves stuff. For example, ssh into the container andyo phovea:_check-own-version
works as expected.