Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed tests and added build task to all branches in circleci #515

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Apr 21, 2022

Closes #514

Developer Checklist (Definition of Done)

  • Descriptive title for this pull request provided (will be used for release notes later)
  • All acceptance criteria from the issue are met
  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Code documentation written
  • Unit tests written
  • Build is successful
  • Summary of changes written
  • Wiki documentation written
  • Assign at least one reviewer
  • Assign at least one assignee
  • Add type label (e.g., bug, enhancement) to this pull request
  • Add next version label (e.g., release: minor) to this PR following semver

Summary of changes

  • Fixed the tests to match some new workspace changes, like the removal of phovea_[core|clue|...] repos a long time ago, or the existance of the /dist/tsBuildInfoFile.
  • Added the build-only job to run in all branches, that's how this was missed in the first place. @anita-steiner was it intended to not be run in any branches? If yes I can remove it, but I think we should keep it right?
    • I couldn't solve the issue with the tests not being able to be run as the phovea:... generators are not found during the tests? Therefore, most tests are failing due to You don't seem to have a generator with the name “phovea:_check-own-version” installed.. I can't really put my finger on the reason, but it might be due to the way tests are run/the testrunner resolves stuff. For example, ssh into the container and yo phovea:_check-own-version works as expected.

@puehringer puehringer added priority: high type: bug Something isn't working release: minor PR merge results in a new minor version labels Apr 21, 2022
@puehringer puehringer requested review from dvvanessastoiber and a user April 21, 2022 07:01
@puehringer puehringer force-pushed the mp/fix_tests branch 4 times, most recently from 44c819c to 8fece2d Compare April 21, 2022 07:18
@puehringer puehringer marked this pull request as draft April 21, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high release: minor PR merge results in a new minor version type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants