Skip to content

Commit

Permalink
Add note to UPGRADING about proc_open changes for invalid command
Browse files Browse the repository at this point in the history
Closes GH-12589
  • Loading branch information
bukka committed Nov 12, 2023
1 parent a687465 commit 3b68df2
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,11 @@ PHP 8.3 UPGRADE NOTES
. password_hash() will now chain the underlying Random\RandomException
as the ValueError’s $previous Exception when salt generation fails.
. proc_open() $command array must now have at least one non empty element.
. proc_open() returns false if $command array is invalid command instead of
resource object that produces warning later. This was already the case for
Windows but it is now also the case if posix_spawn implementation is in use
(most Linux, BSD and MacOS platforms). There are still some old platforms
where this behavior is not changed as posix_spawn is not supported there.
. array_sum() and array_product() now warn when values in the array cannot
be converted to int/float. Previously arrays and objects where ignored
whilst every other value was cast to int. Moreover, objects that define
Expand Down

4 comments on commit 3b68df2

@Girgias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also do a PR on doc-en? Otherwise this is not going to get synchronized.

@bukka
Copy link
Member Author

@bukka bukka commented on 3b68df2 Nov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should I change there?

@Girgias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should I change there?

Add a new paragraph below: https://github.com/php/doc-en/blob/master/appendices/migration83/other-changes.xml#L382-L387 would be where I would put it. :)

@bukka
Copy link
Member Author

@bukka bukka commented on 3b68df2 Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.