Skip to content

Commit

Permalink
xfail STATUS_BAD_FUNCTION_TABLE tests
Browse files Browse the repository at this point in the history
These look related to #15709, but apparently only fail with ASan
instrumentation.  Let's xfail these for now.
  • Loading branch information
cmb69 committed Dec 8, 2024
1 parent fe64579 commit 76f9087
Show file tree
Hide file tree
Showing 5 changed files with 43 additions and 0 deletions.
8 changes: 8 additions & 0 deletions Zend/tests/gh12073.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@ GH-12073: Freeing of non-ZMM pointer of incompletely allocated closure
if (getenv("USE_ZEND_ALLOC") === "0" && getenv("USE_TRACKED_ALLOC") !== "1") {
die("skip Zend MM disabled");
}
$tracing = extension_loaded("Zend OPcache")
&& ($conf = opcache_get_configuration()["directives"])
&& array_key_exists("opcache.jit", $conf)
&& $conf["opcache.jit"] === "tracing";
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing && getenv('SKIP_ASAN')) {
$url = "https://github.com/php/php-src/issues/15709";
die("xfail Test fails on Windows x64 (VS17) and tracing JIT with ASan; see $url");
}
?>
--FILE--
<?php
Expand Down
11 changes: 11 additions & 0 deletions ext/standard/tests/gh14643_longname.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
--TEST--
GH-14643: Segfault on empty user function.
--SKIPIF--
<?php
$tracing = extension_loaded("Zend OPcache")
&& ($conf = opcache_get_configuration()["directives"])
&& array_key_exists("opcache.jit", $conf)
&& $conf["opcache.jit"] === "tracing";
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing && getenv('SKIP_ASAN')) {
$url = "https://github.com/php/php-src/issues/15709";
die("xfail Test fails on Windows x64 (VS17) and tracing JIT with ASan; see $url");
}
?>
--FILE--
<?php
class Logger {
Expand Down
8 changes: 8 additions & 0 deletions tests/basic/timeout_variation_0.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ Timeout within while loop
--SKIPIF--
<?php
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
$tracing = extension_loaded("Zend OPcache")
&& ($conf = opcache_get_configuration()["directives"])
&& array_key_exists("opcache.jit", $conf)
&& $conf["opcache.jit"] === "tracing";
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing && getenv('SKIP_ASAN')) {
$url = "https://github.com/php/php-src/issues/15709";
die("xfail Test fails on Windows x64 (VS17) and tracing JIT with ASan; see $url");
}
?>
--FILE--
<?php
Expand Down
8 changes: 8 additions & 0 deletions tests/basic/timeout_variation_7.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ Timeout within for loop
--SKIPIF--
<?php
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
$tracing = extension_loaded("Zend OPcache")
&& ($conf = opcache_get_configuration()["directives"])
&& array_key_exists("opcache.jit", $conf)
&& $conf["opcache.jit"] === "tracing";
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing && getenv('SKIP_ASAN')) {
$url = "https://github.com/php/php-src/issues/15709";
die("xfail Test fails on Windows x64 (VS17) and tracing JIT with ASan; see $url");
}
?>
--FILE--
<?php
Expand Down
8 changes: 8 additions & 0 deletions tests/func/005a.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@ Testing register_shutdown_function() with timeout. (Bug: #21513)
--SKIPIF--
<?php
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
$tracing = extension_loaded("Zend OPcache")
&& ($conf = opcache_get_configuration()["directives"])
&& array_key_exists("opcache.jit", $conf)
&& $conf["opcache.jit"] === "tracing";
if (PHP_OS_FAMILY === "Windows" && PHP_INT_SIZE == 8 && $tracing && getenv('SKIP_ASAN')) {
$url = "https://github.com/php/php-src/issues/15709";
die("xfail Test fails on Windows x64 (VS17) and tracing JIT with ASan; see $url");
}
?>
--FILE--
<?php
Expand Down

0 comments on commit 76f9087

Please sign in to comment.