Include relevant system headers before defining fallbacks #17129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we may define the fallbacks, and later inclusion of the system headers may attempt to redefine those. Fixes phpGH-17112.
Closed
|
Yeah this seems fine to me for stable branches. |
bukka
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we may define the fallbacks, and later inclusion of the system headers may attempt to redefine those.
Fixes GH-17112.
Note that I don't know if we need to include both arpa/inet.h and netinet/in.h to avoid this issue for
INADDR_NONE, but it likely doesn't hurt, and #17124 seems to be a cleaner solution anyway (however, we cannot apply that to stable branches, so this is more a stop-gap measure).cc @nielsdos (since you've fixed the other part of #17112).