Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/pdo: Refactor PDO::FETCH_CLASS to not rely on a FCI and use a HashTable for ctor_arg #17427

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 10, 2025

Commits should be reviewed in order.

This removes the last usage of zend_fcall_info_args_ex() and basically supersedes #9725, which would allow merging #9723.

This also aligns the behaviour of the ctor_arguments to be have like CUFA.

Some follow-up ideas:

  • Deprecate the automatic wrapping of by-ref arguments for the constructor
  • Figure out how to remove the various dummy fields to reduce the size of the struct

@Girgias Girgias force-pushed the pdo-stmt-remove-fci-usage branch 3 times, most recently from 702f741 to 2bad75c Compare January 15, 2025 19:01
@Girgias Girgias marked this pull request as ready for review January 15, 2025 20:00
@Girgias Girgias requested a review from nielsdos January 15, 2025 20:00
@Girgias Girgias force-pushed the pdo-stmt-remove-fci-usage branch from 2bad75c to 81490b2 Compare January 16, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant