Skip to content

Commit

Permalink
show workflow and plain-language to explain where the failure point is
Browse files Browse the repository at this point in the history
  • Loading branch information
ndvan committed Mar 28, 2018
1 parent f647abf commit 0cbfe12
Show file tree
Hide file tree
Showing 10 changed files with 220 additions and 1 deletion.
1 change: 1 addition & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
--require spec_helper
5 changes: 5 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,11 @@ group :development, :test do

# Use sqlite3 as the database for Active Record
gem 'sqlite3'

gem 'rspec-rails', '~> 3.7'
gem 'capybara'

gem 'poltergeist'
end

group :test do
Expand Down
5 changes: 5 additions & 0 deletions app/controllers/raw_extractions_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def index
res = Req.get(APP_CONFIG["sv_get_public_lists"]["url"])
@public_lists = JSON.parse(res)["lists"] rescue []
@public_lists.sort_by! {|m| m["list_title"].downcase }
respond_to do |format|
format.js
format.html
end

end

def checking_status
Expand Down
3 changes: 3 additions & 0 deletions app/controllers/workflows_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def resolve
end

def alternative_extract_tree
@service = "OToL_wrapper_Tree"
resolved = JSON.parse(@tree.raw_extraction.species)

chosen_species = JSON.parse(@tree.chosen_species).select {|k,v| v == "1"}.map {|k,v| k }
Expand Down Expand Up @@ -99,6 +100,7 @@ def alternative_extract_tree
end

def scale_tree
@service = "Datelife_scale_tree"
@op = 3
scaled_response = Req.post( APP_CONFIG["sv_datelife_tree"]["url"],
{"newick": sanitize_newick(@tree), method: "median"}.to_json,
Expand Down Expand Up @@ -135,6 +137,7 @@ def scale_tree


def extract_tree
@service = "PhyloT_wrapper_Tree"
@op = 2
resolved = JSON.parse(@tree.raw_extraction.species)

Expand Down
1 change: 1 addition & 0 deletions app/views/raw_extractions/index.js.erb
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
window.location.reload(true);
2 changes: 1 addition & 1 deletion app/views/workflows/service_failed.js.erb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
$('#log').append("<div class=\"alert alert-danger\">" + currentTime() + " Call service error<br />");
$('#log').append("<div class=\"alert alert-danger\">" + currentTime() + " Call service " + "<%= @service %>" + " error<br />");

<% unless @e.nil? %>
$('#log').append("<%=j @e %></div>");
Expand Down
40 changes: 40 additions & 0 deletions spec/integration/home_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
require 'spec_helper'

feature 'home page' do
it 'welcomes the user' do
visit '/'
expect(page).to have_content "Welcome"
end
end

feature 'home page' do
it 'welcomes the user' do
visit 'http://0.0.0.0:3000/static_pages/about'
expect(page).to have_content "What we do"
end
end


feature "lets the user", js: true do
before do
visit 'http://0.0.0.0:3000'
end

it 'select a public list' do
page.all(".list-group-item").last.click
expect(page).to have_content "Top 40 popular species"
expect(page).to have_content "Acinonyx jubatus"
end

it 'push \"Get tree\" button' do
page.all(".list-group-item").last.click
click_button "Get tree"
expect(page).to have_selector('.modal-body', visible: true)
within(find(".modal-body")) do
fill_in 'tree_name-9', with: 'Capybana test'
end
find("#psedo-submit-9").click
page.save_screenshot
expect(page).to have_content('Extracting tree')
end
end
57 changes: 57 additions & 0 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
# This file is copied to spec/ when you run 'rails generate rspec:install'
require 'spec_helper'
ENV['RAILS_ENV'] ||= 'test'
require File.expand_path('../../config/environment', __FILE__)
# Prevent database truncation if the environment is production
abort("The Rails environment is running in production mode!") if Rails.env.production?
require 'rspec/rails'
# Add additional requires below this line. Rails is not loaded until this point!

# Requires supporting ruby files with custom matchers and macros, etc, in
# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
# run as spec files by default. This means that files in spec/support that end
# in _spec.rb will both be required and run as specs, causing the specs to be
# run twice. It is recommended that you do not name files matching this glob to
# end with _spec.rb. You can configure this pattern with the --pattern
# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
#
# The following line is provided for convenience purposes. It has the downside
# of increasing the boot-up time by auto-requiring all files in the support
# directory. Alternatively, in the individual `*_spec.rb` files, manually
# require only the support files necessary.
#
# Dir[Rails.root.join('spec/support/**/*.rb')].each { |f| require f }

# Checks for pending migrations and applies them before tests are run.
# If you are not using ActiveRecord, you can remove this line.
ActiveRecord::Migration.maintain_test_schema!

RSpec.configure do |config|
# Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
config.fixture_path = "#{::Rails.root}/spec/fixtures"

# If you're not using ActiveRecord, or you'd prefer not to run each of your
# examples within a transaction, remove the following line or assign false
# instead of true.
config.use_transactional_fixtures = true

# RSpec Rails can automatically mix in different behaviours to your tests
# based on their file location, for example enabling you to call `get` and
# `post` in specs under `spec/controllers`.
#
# You can disable this behaviour by removing the line below, and instead
# explicitly tag your specs with their type, e.g.:
#
# RSpec.describe UsersController, :type => :controller do
# # ...
# end
#
# The different available types are documented in the features, such as in
# https://relishapp.com/rspec/rspec-rails/docs
config.infer_spec_type_from_file_location!

# Filter lines from Rails gems in backtraces.
config.filter_rails_from_backtrace!
# arbitrary gems may also be filtered via:
# config.filter_gems_from_backtrace("gem name")
end
107 changes: 107 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
ENV["RAILS_ENV"] ||= 'test'
require File.expand_path("../../config/environment", __FILE__)
require 'rspec/rails'

# Add this to load Capybara integration:
require 'capybara/rspec'
require 'capybara/rails'
require 'capybara/poltergeist'
Capybara.javascript_driver = :poltergeist

# This file was generated by the `rails generate rspec:install` command. Conventionally, all
# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
# The generated `.rspec` file contains `--require spec_helper` which will cause
# this file to always be loaded, without a need to explicitly require it in any
# files.
#
# Given that it is always loaded, you are encouraged to keep this file as
# light-weight as possible. Requiring heavyweight dependencies from this file
# will add to the boot time of your test suite on EVERY test run, even for an
# individual file that may not need all of that loaded. Instead, consider making
# a separate helper file that requires the additional dependencies and performs
# the additional setup, and require it from the spec files that actually need
# it.
#
# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration

RSpec.configure do |config|
# rspec-expectations config goes here. You can use an alternate
# assertion/expectation library such as wrong or the stdlib/minitest
# assertions if you prefer.
config.expect_with :rspec do |expectations|
# This option will default to `true` in RSpec 4. It makes the `description`
# and `failure_message` of custom matchers include text for helper methods
# defined using `chain`, e.g.:
# be_bigger_than(2).and_smaller_than(4).description
# # => "be bigger than 2 and smaller than 4"
# ...rather than:
# # => "be bigger than 2"
expectations.include_chain_clauses_in_custom_matcher_descriptions = true
end

# rspec-mocks config goes here. You can use an alternate test double
# library (such as bogus or mocha) by changing the `mock_with` option here.
config.mock_with :rspec do |mocks|
# Prevents you from mocking or stubbing a method that does not exist on
# a real object. This is generally recommended, and will default to
# `true` in RSpec 4.
mocks.verify_partial_doubles = true
end

# This option will default to `:apply_to_host_groups` in RSpec 4 (and will
# have no way to turn it off -- the option exists only for backwards
# compatibility in RSpec 3). It causes shared context metadata to be
# inherited by the metadata hash of host groups and examples, rather than
# triggering implicit auto-inclusion in groups with matching metadata.
config.shared_context_metadata_behavior = :apply_to_host_groups

# The settings below are suggested to provide a good initial experience
# with RSpec, but feel free to customize to your heart's content.
=begin
# This allows you to limit a spec run to individual examples or groups
# you care about by tagging them with `:focus` metadata. When nothing
# is tagged with `:focus`, all examples get run. RSpec also provides
# aliases for `it`, `describe`, and `context` that include `:focus`
# metadata: `fit`, `fdescribe` and `fcontext`, respectively.
config.filter_run_when_matching :focus
# Allows RSpec to persist some state between runs in order to support
# the `--only-failures` and `--next-failure` CLI options. We recommend
# you configure your source control system to ignore this file.
config.example_status_persistence_file_path = "spec/examples.txt"
# Limits the available syntax to the non-monkey patched syntax that is
# recommended. For more details, see:
# - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
# - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
# - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
config.disable_monkey_patching!
# Many RSpec users commonly either run the entire suite or an individual
# file, and it's useful to allow more verbose output when running an
# individual spec file.
if config.files_to_run.one?
# Use the documentation formatter for detailed output,
# unless a formatter has already been configured
# (e.g. via a command-line flag).
config.default_formatter = "doc"
end
# Print the 10 slowest examples and example groups at the
# end of the spec run, to help surface which specs are running
# particularly slow.
config.profile_examples = 10
# Run specs in random order to surface order dependencies. If you find an
# order dependency and want to debug it, you can fix the order by providing
# the seed, which is printed after each run.
# --seed 1234
config.order = :random
# Seed global randomization in this process using the `--seed` CLI option.
# Setting this allows you to use `--seed` to deterministically reproduce
# test failures related to randomization by passing the same `--seed` value
# as the one that triggered the failure.
Kernel.srand config.seed
=end
end
Empty file removed test/integration/.keep
Empty file.

0 comments on commit 0cbfe12

Please sign in to comment.