-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6 placeholder #2153
Open
PromoFaux
wants to merge
2,472
commits into
master
Choose a base branch
from
development
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
v6 placeholder #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confusion in the code to free old DHCP configuration when it's being reloaded causes invalid pointers to be followed and a crash. https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q4/017764.html has a more complete explanation of the problem. Signed-off-by: DL6ER <[email protected]>
Improve QPS calculation
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Print size of database / count of removed rows only in debug mode
Do not try to access vector items if (re)allocation failed
Signed-off-by: DL6ER <[email protected]>
Fix compilation support on Ubuntu 24.04.1 LTS
…by Pi-hole Signed-off-by: DL6ER <[email protected]>
Update rapidoc and highlight
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…them. Also simplify code by changing index counters to unsigned types. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Amend help text to database.maxDBdays
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Co-authored-by: yubiuser <[email protected]> Signed-off-by: Dominik <[email protected]>
…pstreams Only consider NXDOMAIN replies as indication of external blocking if both the RA and AA bit are unset. Signed-off-by: Felix Kaechele <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…ssary to do this. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Fix external block detection on NXDOMAIN replies from authoritative upstreams
Make maximum number of threads used by web server configurable
Signed-off-by: DL6ER <[email protected]>
CI: Remove NTP test
Signed-off-by: catch-error <[email protected]>
…ignal Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Harden dnsmasq syntax checking against signals
…d in the help output as it is solely meant to be used internally by the installer script once from v5 -> v6 Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
…is not available (e.g. broken or more recent than this particular FTL binary can handle (like checking out a very old branch)) Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: Adam Warner <[email protected]>
Allow .ssh directory to be mounted on MacOS host
Prevent calling strcmp with NULL pointer
Fix file ownership after pihole-FTL --config as root
…nly mention it when debug.config is true. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
If dnsmasq is configured to add an EDNS client subnet to a query, it is careful to suppress use of the cache, since a cached answer may not be valid for a query with a different client subnet. Extend this behaviour to queries which arrive a dnsmasq already carrying an EDNS client subnet. This change is rather more involved than may seem necessary at first sight, since the existing code relies on all queries being decorated by dnsmasq and therefore not cached, so there is no chance that an incoming query might hit the cache and cache lookup don't need to be suppressed, just cache insertion. When downstream queries may be a mix of client-subnet bearing and plain vanilla, it can't be assumed that the answers are never in the cache, and queries with subnets must not do lookups. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
I misread the man page for socket(7) and TCP timeouts. A timeout generates a -1 return and EAGAIN errno, NOT a short read. Short reads are legit, and aborting when they are seen creates hard-to-reproduce errors. Signed-off-by: DL6ER <[email protected]>
Print a specific INFO message instead of a generic WARNING message, so users aren't inconvenienced and maintainers know what to do. Debian currently runs this service as part of NetworkManager, in a systemd service without CAP_CHOWN. Other distributions may have the same problem, or might add the issue in future. This fix should communicate the issue clearly to them. Signed-off-by: DL6ER <[email protected]>
I have no memory for why this was ever there. It breaks DNSSEC validation of large RRsets. I can't see any DoS potential that is exposed by removing it. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
Update dnsmasq to v2.91test6
…st-updated timestamp from the gravity database Signed-off-by: DL6ER <[email protected]>
…ON tables to the gravity database Signed-off-by: DL6ER <[email protected]>
…in-memory Teleporter database Signed-off-by: DL6ER <[email protected]>
Add new explicit migration command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ducks in a row...