Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6 placeholder #2153

Open
wants to merge 2,472 commits into
base: master
Choose a base branch
from
Open

v6 placeholder #2153

wants to merge 2,472 commits into from

Conversation

PromoFaux
Copy link
Member

Getting ducks in a row...

DL6ER and others added 30 commits October 4, 2024 19:21
Confusion in the code to free old DHCP configuration when it's
being reloaded causes invalid pointers to be followed and a crash.

https://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2024q4/017764.html

has a more complete explanation of the problem.

Signed-off-by: DL6ER <[email protected]>
Print size of database / count of removed rows only in debug mode
Do not try to access vector items if (re)allocation failed
Fix compilation support on Ubuntu 24.04.1 LTS
…them. Also simplify code by changing index counters to unsigned types.

Signed-off-by: DL6ER <[email protected]>
Amend help text to database.maxDBdays
Co-authored-by: yubiuser <[email protected]>
Signed-off-by: Dominik <[email protected]>
…pstreams

Only consider NXDOMAIN replies as indication of external blocking if
both the RA and AA bit are unset.

Signed-off-by: Felix Kaechele <[email protected]>
Fix external block detection on NXDOMAIN replies from authoritative upstreams
DL6ER and others added 30 commits January 1, 2025 20:30
Make maximum number of threads used by web server configurable
Signed-off-by: DL6ER <[email protected]>
Harden dnsmasq syntax checking against signals
…d in the help output as it is solely meant to be used internally by the installer script once from v5 -> v6

Signed-off-by: DL6ER <[email protected]>
…is not available (e.g. broken or more recent than this particular FTL binary can handle (like checking out a very old branch))

Signed-off-by: DL6ER <[email protected]>
Allow .ssh directory to be mounted on MacOS host
Prevent calling strcmp with NULL pointer
Fix file ownership after pihole-FTL --config as root
…nly mention it when debug.config is true.

Signed-off-by: DL6ER <[email protected]>
If dnsmasq is configured to add an EDNS client subnet to a query,
it is careful to suppress use of the cache, since a cached answer may
not be valid for a query with a different client subnet.
Extend this behaviour to queries which arrive a dnsmasq
already carrying an EDNS client subnet.

This change is rather more involved than may seem necessary at first sight,
since the existing code relies on all queries being decorated by dnsmasq
and therefore not cached, so there is no chance that an incoming query
might hit the cache and cache lookup don't need to be suppressed, just
cache insertion. When downstream queries may be a mix of client-subnet
bearing and plain vanilla, it can't be assumed that the answers are never
in the cache, and queries with subnets must not do lookups.

Signed-off-by: DL6ER <[email protected]>
I misread the man page for socket(7) and TCP timeouts.

A timeout generates a -1 return and EAGAIN errno, NOT a short read.

Short reads are legit, and aborting when they are seen creates
hard-to-reproduce errors.

Signed-off-by: DL6ER <[email protected]>
Print a specific INFO message instead of a generic WARNING message,
so users aren't inconvenienced and maintainers know what to do.

Debian currently runs this service as part of NetworkManager,
in a systemd service without CAP_CHOWN.  Other distributions may
have the same problem, or might add the issue in future.
This fix should communicate the issue clearly to them.

Signed-off-by: DL6ER <[email protected]>
I have no memory for why this was ever there. It breaks DNSSEC
validation of large RRsets.

I can't see any DoS potential that is exposed by removing it.

Signed-off-by: DL6ER <[email protected]>
…st-updated timestamp from the gravity database

Signed-off-by: DL6ER <[email protected]>
…ON tables to the gravity database

Signed-off-by: DL6ER <[email protected]>
Add new explicit migration command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants