Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix flag icon preview #164

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[Bug] Fix flag icon preview #164

merged 1 commit into from
Dec 4, 2024

Conversation

mattamon
Copy link
Contributor

@mattamon mattamon commented Dec 4, 2024

Resolves #162

@mattamon mattamon added the Bug label Dec 4, 2024
@mattamon mattamon added this to the 1.7.4 milestone Dec 4, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mattamon mattamon requested a review from kingjia90 December 4, 2024 07:54
@kingjia90 kingjia90 self-assigned this Dec 4, 2024
kingjia90
kingjia90 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From config editing and this bundle pov LGTM.

Need also a followup in admin ui, it's still stretched in the menu tree

image

Could be fixed by adding background-size:contain to .x-menu-item-icon-default by quickly trying in the web dev tool
image

Need to double-check other places where the icon might be used

@mattamon
Copy link
Contributor Author

mattamon commented Dec 4, 2024

From config editing and this bundle pov LGTM.

Need also a followup in admin ui, it's still stretched in the menu tree image

Could be fixed by adding background-size:contain to .x-menu-item-icon-default by quickly trying in the web dev tool image

Need to double-check other places where the icon might be used

Yeah I thought about that too! Let's check the other bundles! :)

@kingjia90 kingjia90 linked an issue Dec 4, 2024 that may be closed by this pull request
[Bug]: Flag icon preview is incorrect #162
Closed
@mattamon mattamon merged commit 8e7494a into 1.7 Dec 4, 2024
8 checks passed
@mattamon mattamon deleted the 162-fix-flag-background branch December 4, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingjia90 kingjia90 kingjia90 approved these changes

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
1.7.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Flag icon preview is incorrect
2 participants
@mattamon @kingjia90