Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear thumbnails endpoint for videos and pdfs #699

Open
Corepex opened this issue Jan 16, 2025 · 2 comments · May be fixed by #700
Open

Clear thumbnails endpoint for videos and pdfs #699

Corepex opened this issue Jan 16, 2025 · 2 comments · May be fixed by #700

Comments

@Corepex
Copy link
Contributor

Corepex commented Jan 16, 2025

We already have an endpoint to clear the thumbnails for images.

We would need the same endpoint for videos and pdfs.

In the old UI, everything seems to have the same URL:
https://github.com/pimcore/admin-ui-classic-bundle/blob/2.x/public/js/pimcore/asset/asset.js#L316

In the new UI, we split the logic, so feel free to create two endpoints to match the current approach.
@Corepex Corepex mentioned this issue Jan 16, 2025
Merged
@mattamon mattamon linked a pull request Jan 16, 2025 that will close this issue
Open
@mattamon
Copy link
Contributor

@Corepex I guess it is simpler to just use one route for all since it is the same call anyways and splitting this up in 3 different routes just creates code dupes.

@Corepex
Copy link
Contributor Author

Corepex commented Jan 16, 2025

@Corepex I guess it is simpler to just use one route for all since it is the same call anyways and splitting this up in 3 different routes just creates code dupes.

sure also possible - whatever floats your boat 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make thumbnail clear available for images/videos/pdfs pimcore/studio-backend-bundle
2 participants
@Corepex @mattamon