Added context menu to editor toolbar #869
Conversation
…ions-editor-context-menu
…ions-editor-context-menu # Conflicts: # assets/js/src/core/modules/asset/editor/title/title-container.tsx # public/build/bc44126d-610b-4a77-ab4c-f7311953b828/core-dll.css
…ctions-editor-context-menu' into 753-missing-asset-context-menu-actions-editor-context-menu
…ctions-editor-context-menu' into 753-missing-asset-context-menu-actions-editor-context-menu
…`data-object` editor
…ctions-editor-context-menu' into 753-missing-asset-context-menu-actions-editor-context-menu
| } | ||
|
|
||
| const clearThumbnailContextMenuItem = (node: Asset, onFinish?: () => void): ItemType => { | ||
| return { |
There was a problem hiding this comment.
For permission and hidden checks take a look here:
https://github.com/pimcore/admin-ui-classic-bundle/blob/2.x/public/js/pimcore/asset/asset.js#L316
We need to do the same checks like in the classic bundle. E.g. it should also work for videos - does this work on backend side?
There was a problem hiding this comment.
improved with cc3b3b0
I am currently waiting for the correct icon.
There was a problem hiding this comment.
It seems that the BE doesn't support video and pdf thumbnails right now. I created an issue to patch that. pimcore/studio-backend-bundle#699
| @@ -38,8 +38,8 @@ export const GridActions = (): React.JSX.Element => { | |||
| const { page } = useListPage() | |||
| const { id } = useAsset() | |||
|
|
|||
| const { createZipDownload: createZipFolderDownload } = useZipDownload({ type: 'folder' }) | |||
| const { createZipDownload: createZipAssetListDownload } = useZipDownload({ type: 'asset-list' }) | |||
| const { createZipDownload: createZipFolderDownload } = useZipDownload({ elementType: 'asset', type: 'folder' }) | |||
There was a problem hiding this comment.
Why do we need to pass the elementType here allthough useZipDownload() is an asset specific action?
There was a problem hiding this comment.
That is true, I don't know why I didn't notice it in earlier PRs 😆 .
I removed the elementType in d40ea76
…ctions-editor-context-menu' into 753-missing-asset-context-menu-actions-editor-context-menu
…ctions-editor-context-menu' into 753-missing-asset-context-menu-actions-editor-context-menu
|
Corepex
deleted the
753-missing-asset-context-menu-actions-editor-context-menu
branch
Belongs to: #753
Additional info
This pull request introduces several enhancements and additions to the asset management functionality, particularly focusing on context menu items for asset actions. The most important changes include the creation of a new hook for clearing thumbnails, updates to the zip download functionality, and the integration of these new actions into various context menus.
Enhancements and Additions:
New Hook for Clearing Thumbnails:
assets/js/src/core/modules/asset/actions/clear-thumbnails/use-clear-thumbnails.tsx: Created a new hookuseClearThumbnailsto handle the clearing of thumbnails for assets.Zip Download Functionality:
assets/js/src/core/modules/asset/actions/zip-download/use-zip-download.tsx:Integration into Context Menus:
Editor Toolbar Context Menu:
assets/js/src/core/modules/asset/editor/toolbar/context-menu/context-menu.tsx: Integrated the newclearThumbnailContextMenuItemandcreateZipDownloadContextMenuIteminto the editor toolbar context menu. [1] [2]Grid Actions:
assets/js/src/core/modules/asset/editor/types/folder/tab-manager/tabs/list/toolbar/tools/grid-actions.tsx: Updated the zip download actions to include theelementTypeproperty.Tree Context Menus:
assets/js/src/core/modules/asset/tree/context-menu/context-menu.tsx: ReplacedcreateZipDownloadContextMenuItemwithcreateZipDownloadTreeContextMenuItemfor more specific context in the asset tree. [1] [2]assets/js/src/core/modules/data-object/tree/context-menu/context-menu.tsx: Similarly updated the data object tree context menu to usecreateZipDownloadTreeContextMenuItem. [1] [2]