Added cache clear to asset view tab #884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -51,6 +54,14 @@ const FlexContainer = (props: FlexContainerProps): React.JSX.Element => { | |||
| }) | |||
| } | |||
|
|
|||
| const clearCache = (): void => { | |||
There was a problem hiding this comment.
Shouldn't we do this somewhere inside of the action so that the cache clears in all cases when the asset gets deleted? And in addition to that shouldn't we use our new useElementRefresh then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #775
Additional info
This pull request includes enhancements to the asset API slice and the FlexContainer component. The most important changes are the addition of type imports, the enhancement of the
assetGetTreeendpoint, and the integration of cache invalidation in the FlexContainer component.Enhancements to the asset API slice:
assets/js/src/core/modules/asset/asset-api-slice-enhanced.ts: Added type import forTagto improve type safety.assets/js/src/core/modules/asset/asset-api-slice-enhanced.ts: EnhancedassetGetTreeendpoint to provide more specific tags based on the result items.Improvements to FlexContainer component:
assets/js/src/core/modules/asset/editor/types/folder/tab-manager/tabs/preview/flex-container.tsx: Added imports forassetApi,useAppDispatch, andinvalidatingTagsto support cache invalidation.assets/js/src/core/modules/asset/editor/types/folder/tab-manager/tabs/preview/flex-container.tsx: IntegrateduseAppDispatchto the FlexContainer component.assets/js/src/core/modules/asset/editor/types/folder/tab-manager/tabs/preview/flex-container.tsx: AddedclearCachefunction to invalidate cache for asset details and updateddeleteContextMenuItemto use this function. [1] [2]