Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add indexes for mysql.analyze_jobs (#58134) #58355

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58134

What problem does this PR solve?

Issue Number: close #57996

Problem Summary:

What changed and how does it work?

This PR added two indexes for the mysql.analyze_jobs to speed up queries.

I also bumped the bootstrap version from 239 to 140.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

为 `mysql.analyze_jobs` 添加索引加速查询
Add some indexes to `mysql.analyze_jobs` to speed up queries

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 17, 2024
Signed-off-by: Rustin170506 <[email protected]>
Signed-off-by: Rustin170506 <[email protected]>
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@678b713). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58355   +/-   ##
================================================
  Coverage               ?   56.8450%           
================================================
  Files                  ?       1770           
  Lines                  ?     627441           
  Branches               ?          0           
================================================
  Hits                   ?     356669           
  Misses                 ?     246733           
  Partials               ?      24039           
Flag Coverage Δ
integration 36.6953% <0.0000%> (?)
unit 72.6049% <57.1428%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.2743% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024
Copy link

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-20 08:58:59.635942787 +0000 UTC m=+1206529.724745329: ☑️ agreed by Rustin170506.
  • 2024-12-20 09:29:42.414713256 +0000 UTC m=+1208372.503515796: ☑️ agreed by AilinKid.

@Rustin170506
Copy link
Member

/hold

Better to add another check before adding the index.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@Rustin170506
Copy link
Member

/retest

1 similar comment
@Rustin170506
Copy link
Member

/retest

@Rustin170506
Copy link
Member

/unhold

/retest

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Cherry pick PR approved by release team. labels Jan 9, 2025
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@Rustin170506 Rustin170506 requested a review from Leavrth January 10, 2025 14:02
@Rustin170506
Copy link
Member

/assign benmeadowcroft

Copy link

ti-chi-bot bot commented Jan 10, 2025

@Rustin170506: GitHub didn't allow me to assign the following users: benmeadowcroft.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Rustin170506 Rustin170506 added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 10, 2025
@ti-chi-bot ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jan 10, 2025
Copy link

ti-chi-bot bot commented Jan 10, 2025

@Rustin170506: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform.

In response to adding label named cherry-pick-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 11, 2025
Copy link

ti-chi-bot bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, benmeadowcroft, Rustin170506, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 13, 2025
@ti-chi-bot ti-chi-bot bot merged commit f0db14c into pingcap:release-8.5 Jan 13, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants