Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: better systable replacement in full restore #58662

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Jan 2, 2025

What problem does this PR solve?

Issue Number: close #58757 close #58663

Problem Summary:

1.Restore doesn't check the compatibility of mysql.bind_info
2.Replace existed systable could be accelerated

What changed and how does it work?

Instead of replace into the temp sys table from upstream, we could replace into from the downstream tables to the temp tables. After that, Rename the temp table to replace the downstream tables.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
Copy link

ti-chi-bot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Jan 2, 2025

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.5568%. Comparing base (6463db6) to head (5e30f4e).

Current head 5e30f4e differs from pull request most recent head 5ba5b29

Please upload reports for the commit 5ba5b29 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58662        +/-   ##
================================================
+ Coverage   73.1028%   74.5568%   +1.4540%     
================================================
  Files          1677       1700        +23     
  Lines        463911     484111     +20200     
================================================
+ Hits         339132     360938     +21806     
+ Misses       103915     101054      -2861     
- Partials      20864      22119      +1255     
Flag Coverage Δ
integration 45.9594% <100.0000%> (?)
unit 72.3427% <66.6666%> (+0.0472%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 58.6690% <100.0000%> (+12.9180%) ⬆️

Copy link

ti-chi-bot bot commented Jan 10, 2025

@RidRisR: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 5ba5b29 link true /test check-dev2
idc-jenkins-ci-tidb/build 5ba5b29 link true /test build
idc-jenkins-ci-tidb/unit-test 5ba5b29 link true /test unit-test
pull-integration-ddl-test 5ba5b29 link true /test pull-integration-ddl-test
pull-mysql-client-test 5ba5b29 link true /test pull-mysql-client-test
pull-br-integration-test 5ba5b29 link true /test pull-br-integration-test
pull-integration-e2e-test 5ba5b29 link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/mysql-test 5ba5b29 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev 5ba5b29 link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RidRisR RidRisR changed the title br: better systable check in full restore br: better systable replacement in full restore Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br: mysql privilege tables restore acceleration br: sys table restore check omit the binf_info
1 participant