-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: better systable replacement in full restore #58662
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @RidRisR. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58662 +/- ##
================================================
+ Coverage 73.1028% 74.5568% +1.4540%
================================================
Files 1677 1700 +23
Lines 463911 484111 +20200
================================================
+ Hits 339132 360938 +21806
+ Misses 103915 101054 -2861
- Partials 20864 22119 +1255
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@RidRisR: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #58757 close #58663
Problem Summary:
1.Restore doesn't check the compatibility of
mysql.bind_info
2.Replace existed systable could be accelerated
What changed and how does it work?
Instead of
replace into
the temp sys table from upstream, we couldreplace into
from the downstream tables to the temp tables. After that,Rename
the temp table to replace the downstream tables.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.