Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: move 'model' to 'ast' pkg #58704

Merged
merged 4 commits into from
Jan 7, 2025
Merged

parser: move 'model' to 'ast' pkg #58704

merged 4 commits into from
Jan 7, 2025

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jan 6, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

this is the follow up PR of #55754, as we are in 9.0 sprint now, it's ok to do some changes for parser.that breaks other outside components that depends on parser.

after this PR, there is no need to rename it to pmodel all the time when used together with meta/model

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • only move 2 files of parser. I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. component/dumpling This is related to Dumpling of TiDB. sig/planner SIG: Planner labels Jan 6, 2025
@tiprow tiprow
Copy link

tiprow bot commented Jan 6, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.67780% with 22 lines in your changes missing coverage. Please review.

Project coverage is 75.4228%. Comparing base (cf208cf) to head (d747033).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58704        +/-   ##
================================================
+ Coverage   73.0775%   75.4228%   +2.3452%     
================================================
  Files          1677       1723        +46     
  Lines        463762     478517     +14755     
================================================
+ Hits         338906     360911     +22005     
+ Misses       103984      95135      -8849     
- Partials      20872      22471      +1599
Flag Coverage Δ
integration 49.2896% <69.8947%> (?)
unit 72.7318% <89.5874%> (+0.4751%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <100.0000%> (ø)
parser ∅ <ø> (∅)
br 61.7270% <100.0000%> (+16.0030%) ⬆️

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 6, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 6, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-06 11:21:46.408785545 +0000 UTC m=+179849.697617252: ☑️ agreed by lance6716.
  • 2025-01-07 04:10:50.461254999 +0000 UTC m=+240393.750086739: ☑️ agreed by lcwangchao.

GMHDBJD
GMHDBJD approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 7, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, benmeadowcroft, D3Hunter, GMHDBJD, hawkingrei, lance6716, lcwangchao, tiancaiamao, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 7, 2025
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 7, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 7, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Jan 7, 2025

/retest

@tiprow tiprow
Copy link

tiprow bot commented Jan 7, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit b2f2faa into pingcap:master Jan 7, 2025
32 checks passed
@D3Hunter D3Hunter deleted the move-parser-model branch January 7, 2025 10:25
breezewish added a commit that referenced this pull request Jan 8, 2025
@breezewish
Merge commit '510d0037b18f258f505abc6cf13a8128563e9359' into wenxuan/…
3f825ba 
…long-vector

* commit '510d0037b18f258f505abc6cf13a8128563e9359':
  *: upgrade pd client to make sure tso client initiate successfully (#58752)
  ttl, test: scale TTL workers during the fault tests (#58750)
  planner: improve warning messages for unsupported HASH_JOIN hints (#58646)
  planner: prealloc the slices in the SplitCorColAccessCondFromFilters (#58785)
  ddl: supports non-unique global index (#58678)
  util/stmtsummary: add the network traffic related fields (#58101)
  var: enable `pd_enable_follower_handle_region` as default (#58385)
  statistics: refactor stats meta handling to use DeltaUpdate for multi-table support (#58657)
  parser: move 'model' to 'ast' pkg (#58704)
  statistics: add recover to protect background task (#58739)
  disttask: cancel subtask context if scheduled away (#58615)
  *: don't handle live updates of column size (#58596)
  *: fix a bug for default_authentication_plugin (2) (#58723)
  dupdetect: gRPC cancel should trigger retry (#58542)
  *: fix a bug for default_authentication_plugin (#57391)
  distsql: Fix backoff execution info inaccurate issue (#58707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@3pointer 3pointer 3pointer approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@lance6716 lance6716 lance6716 approved these changes

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@benmeadowcroft benmeadowcroft benmeadowcroft approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

Assignees
No one assigned
Labels
approved component/dumpling This is related to Dumpling of TiDB. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@D3Hunter @lcwangchao @benmeadowcroft @tiancaiamao @lance6716 @hawkingrei @3pointer @XuHuaiyu @GMHDBJD