-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br/restore/log_client: use input ts as filter #58734
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. |
Hi @YuJuncen. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #58734 +/- ##
================================================
+ Coverage 73.1049% 75.0341% +1.9292%
================================================
Files 1677 1693 +16
Lines 463762 474553 +10791
================================================
+ Hits 339033 356077 +17044
+ Misses 103897 96289 -7608
- Partials 20832 22187 +1355
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: hillium <[email protected]>
/build |
/rebuild |
/test build |
/retest-required |
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
What problem does this PR solve?
Issue Number: close #58733
Problem Summary:
We use
compaction_from|until_ts
as filter, which may mistakenly filter out something we actually needing.What changed and how does it work?
Use
input_min|max_ts
instead.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.