Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/restore/log_client: use input ts as filter #58734

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jan 7, 2025

What problem does this PR solve?

Issue Number: close #58733

Problem Summary:
We use compaction_from|until_ts as filter, which may mistakenly filter out something we actually needing.

What changed and how does it work?

Use input_min|max_ts instead.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: hillium <[email protected]>
Signed-off-by: hillium <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2025
Copy link

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Jan 7, 2025

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.0341%. Comparing base (1756a8d) to head (b354265).
Report is 15 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58734        +/-   ##
================================================
+ Coverage   73.1049%   75.0341%   +1.9292%     
================================================
  Files          1677       1693        +16     
  Lines        463762     474553     +10791     
================================================
+ Hits         339033     356077     +17044     
+ Misses       103897      96289      -7608     
- Partials      20832      22187      +1355     
Flag Coverage Δ
integration 45.9856% <0.0000%> (?)
unit 72.3130% <100.0000%> (+0.0189%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6163% <100.0000%> (+15.8713%) ⬆️

Signed-off-by: hillium <[email protected]>
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 7, 2025

/build

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 7, 2025

/rebuild

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 7, 2025

/test build

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Jan 7, 2025

/retest-required

Copy link

tiprow bot commented Jan 7, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

tiprow bot commented Jan 7, 2025

@YuJuncen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log_client: should use input_min_ts and input_max_ts to filter compactions
1 participant