Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workloadrepo: Use better error codes for errors in the Workload Repository. #58866

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wddevries
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #58247

Problem Summary:
The workload repository currently returns ErrUnknown(1105) for all errors.

What changed and how does it work?

This pull request:

  • adds an error message in createPartition() for failures when generating partition definitions
  • adds error handing to generatePartitionDef()
  • changes variable handers to return ErrWrongValueForVar when value parsing fails
  • changes the workload repository to return ErrNotSupportedYet when enabled without an etcd server
  • updates the variables test to validate the changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 10, 2025
Copy link

ti-chi-bot bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lidezhu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 10, 2025
Copy link

tiprow bot commented Jan 10, 2025

Hi @wddevries. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes missing coverage. Please review.

Project coverage is 73.6211%. Comparing base (9d0fb30) to head (0adc651).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58866        +/-   ##
================================================
+ Coverage   73.1094%   73.6211%   +0.5116%     
================================================
  Files          1676       1677         +1     
  Lines        463866     467082      +3216     
================================================
+ Hits         339130     343871      +4741     
+ Misses       103877     102297      -1580     
- Partials      20859      20914        +55     
Flag Coverage Δ
integration 42.8036% <0.0000%> (?)
unit 72.2985% <44.4444%> (-0.0199%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7359% <ø> (-0.0090%) ⬇️

@@ -80,8 +81,11 @@ func (w *worker) resetSamplingInterval(newRate int32) {

func (w *worker) changeSamplingInterval(_ context.Context, d string) error {
n, err := strconv.Atoi(d)
if testIntervalParseFailures {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use failpoint.Inject functions? Those functions will be enabled on CI, but eliminated when building actual server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants