Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several network stats issues #9783

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Jan 13, 2025

What problem does this PR solve?

Issue Number: ref #9748

Problem Summary:

What is changed and how it works?

Fix several issues for network traffic stats:

  1. Two typo-like issues for mixing variable names. Previously, no tidb side changes, so only checks the remote coprocessor read code path manually, This time tests with tidb side changes, found these issues. RT.
  2. Currently, in exchange sender side, we stats very small packets which don't look like data packets, with size <= 2 bytes; while in receiver side, these packets are not found. Maybe they include eof or other kinds of packets. Since they are so small that we can just ignore them now.
  3. For fine grained shuffle exchange receiver, the network traffic is counted duplicatedly.

Check List

Tests

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2025
Signed-off-by: yibin <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2025
@yibin87 yibin87 changed the title Fix two typo-like issues introduced by PR9747 Fix several network stats issues Jan 14, 2025
Signed-off-by: yibin <[email protected]>
Signed-off-by: yibin <[email protected]>
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-14 08:24:36.396290084 +0000 UTC m=+20547.851336230: ☑️ agreed by windtalker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants