Include connection IDs in serialized state #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates state serialization and deserialization to include connection IDs if they were negotiated. Signed-off-by: Daniel Mangum <[email protected]>
hasheddan
force-pushed
the
feat/resume-cid
branch
from
6178378 to
da2bb0a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 77.49% 77.53% +0.03%
==========================================
Files 101 101
Lines 6420 6431 +11
==========================================
+ Hits 4975 4986 +11
Misses 1067 1067
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Updates the flight0handler to clear connection IDs in the event the client is attempting to resume an existing session. If connection IDs are to be used in the resumed session, they should be negotiated afresh. https://datatracker.ietf.org/doc/html/rfc9146#section-3 Signed-off-by: Daniel Mangum <[email protected]>
hasheddan
force-pushed
the
feat/resume-cid
branch
from
da2bb0a to
978b317
Compare
hasheddan
commented
Aug 28, 2023
There was a problem hiding this comment.
Example of using this functionality demonstrated in plgd-dev/go-coap#473
edaniels
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates state serialization and deserialization to include connection
IDs if they were negotiated.
Signed-off-by: Daniel Mangum [email protected]
Updates the flight0handler to clear connection IDs in the event the
client is attempting to resume an existing session. If connection IDs
are to be used in the resumed session, they should be negotiated afresh.
https://datatracker.ietf.org/doc/html/rfc9146#name-the-connection_id-extension
Signed-off-by: Daniel Mangum [email protected]