Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golangci-lint, more linters #65

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Upgrade golangci-lint, more linters #65

merged 1 commit into from
Jan 12, 2025

Conversation

joeturki
Copy link
Member

Description

New linters and resolves issues with the latest golangci-lint version (v1.63.4).

Reference issue

pion/.goassets#220

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 82.88288% with 19 lines in your changes missing coverage. Please review.

Project coverage is 70.39%. Comparing base (e8536fe) to head (cf304dd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/silk/decoder.go 78.37% 15 Missing and 1 partial ⚠️
decoder.go 88.88% 1 Missing ⚠️
pkg/oggreader/oggreader.go 94.11% 0 Missing and 1 partial ⚠️
table_of_contents_header.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   60.77%   70.39%   +9.61%     
==========================================
  Files           8        8              
  Lines        1081     1692     +611     
==========================================
+ Hits          657     1191     +534     
- Misses        398      475      +77     
  Partials       26       26              
Flag Coverage Δ
go 70.39% <82.88%> (+9.61%) ⬆️
wasm 69.03% <81.98%> (+10.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@joeturki joeturki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeturki joeturki merged commit 08e06e0 into master Jan 12, 2025
15 checks passed
@joeturki joeturki deleted the impr/lint branch January 12, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant