Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize unmarshal type handling #174

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Optimize unmarshal type handling #174

merged 1 commit into from
Mar 6, 2024

Conversation

Sean-Der
Copy link
Member

@Sean-Der Sean-Der commented Mar 6, 2024

Dispatch type as a byte, instead of allocating a string

Before
'''
14433 ns/op 2576 B/op 108 allocs/op
'''

After
'''
13616 ns/op 2512 B/op 83 allocs/op
'''

Dispatch type as a byte, instead of allocating a string

Before
'''
14433 ns/op          2576 B/op      108 allocs/op
'''

After
'''
13616 ns/op          2512 B/op       83 allocs/op
'''
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 64.22%. Comparing base (37a57e6) to head (1322d2c).
Report is 1 commits behind head on master.

Files Patch % Lines
unmarshal.go 71.60% 23 Missing ⚠️
base_lexer.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   64.28%   64.22%   -0.07%     
==========================================
  Files          11       11              
  Lines        1540     1526      -14     
==========================================
- Hits          990      980      -10     
+ Misses        449      446       -3     
+ Partials      101      100       -1     
Flag Coverage Δ
go 64.22% <71.42%> (-0.07%) ⬇️
wasm 64.22% <71.42%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit adf8269 into master Mar 6, 2024
14 checks passed
@Sean-Der Sean-Der deleted the sean-optimize branch March 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant