Skip padding packet for simulcast probe #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnderrauber
requested review from
davidzhao,
Sean-Der,
boks1971 and
adriancable
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2655 +/- ##
=======================================
Coverage 76.37% 76.37%
=======================================
Files 87 87
Lines 9895 9905 +10
=======================================
+ Hits 7557 7565 +8
- Misses 1866 1868 +2
Partials 472 472
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
boks1971
approved these changes
Feb 2, 2024
Skip padding packet for simulcast probe Fix rtx attributes panic for nil map
cnderrauber
force-pushed
the
skip_padding_simulcast
branch
from
519c332 to
0e70684
Compare
adriancable
approved these changes
Feb 2, 2024
davidzhao
approved these changes
Feb 2, 2024
boks1971
reviewed
Feb 2, 2024
| PayloadType: 96, | ||
| Padding: true, | ||
| }, | ||
| Payload: []byte{0x00, 0x02}, |
There was a problem hiding this comment.
@cnderrauber Sorry, missed this. This has two byte payload, but the check for padding only checks for Padding == true && payload length is zero. Here it is not. I am guessing this is not fulfilling rids because the extension is not set.
There was a problem hiding this comment.
Oops, please ignore me. The payload last byte is padding size. My bad. Sorry about the fake news.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip padding packet for simulcast probe
Fix rtx attributes panic for nil map