Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ice to v3.0.3 for mdns fix #2669

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Update ice to v3.0.3 for mdns fix #2669

merged 1 commit into from
Feb 8, 2024

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Feb 8, 2024

Fixes #2625

Will backport to v3 after tests pass in each branch.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2407bf2) 76.36% compared to head (a930929) 64.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2669       +/-   ##
===========================================
- Coverage   76.36%   64.54%   -11.83%     
===========================================
  Files          87       64       -23     
  Lines        9921     3689     -6232     
===========================================
- Hits         7576     2381     -5195     
+ Misses       1873     1180      -693     
+ Partials      472      128      -344     
Flag Coverage Δ
go ?
wasm 64.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit 6884334 into master Feb 8, 2024
14 of 15 checks passed
@edaniels edaniels deleted the update_mdns branch February 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TestMulticastDNSCandidates fail probabilistically in local
1 participant