Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TrackLocal RTX #2676

Closed
wants to merge 1 commit into from

Conversation

aggresss
Copy link
Member

Description

RetransmittedPacketsReceived/PacketsLost can be accurately measured, if use distinct SSRC to transmit RTX.

See Also: pion/interceptor#229

Reference issue

Supports TrackLocal RTX

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 16.25000% with 67 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (dbf2254) to head (ca3d6b4).
Report is 127 commits behind head on master.

Files with missing lines Patch % Lines
rtpsender.go 5.08% 53 Missing and 3 partials ⚠️
sdp.go 0.00% 4 Missing and 2 partials ⚠️
rtpcodec.go 76.92% 2 Missing and 1 partial ⚠️
settingengine.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2676      +/-   ##
==========================================
- Coverage   76.47%   75.92%   -0.56%     
==========================================
  Files          87       87              
  Lines        9922    10002      +80     
==========================================
+ Hits         7588     7594       +6     
- Misses       1862     1931      +69     
- Partials      472      477       +5     
Flag Coverage Δ
go 77.39% <16.25%> (-0.62%) ⬇️
wasm 64.31% <0.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aggresss aggresss force-pushed the feature/distict_nack_001 branch from f63cfe7 to b79487b Compare February 21, 2024 02:01
@aggresss aggresss requested a review from Sean-Der February 21, 2024 04:54
@aggresss aggresss force-pushed the feature/distict_nack_001 branch from b79487b to 9476f01 Compare February 22, 2024 08:14
@aggresss aggresss force-pushed the feature/distict_nack_001 branch from 9476f01 to ca3d6b4 Compare February 22, 2024 23:47
@Sean-Der
Copy link
Member

Sean-Der commented Oct 3, 2024

Thank you so much for this PR @aggresss sorry I didn't merge it sooner. I was distracted by OBS and then DTLS :/

I have cherry-picked your change into #2676 and writing some tests/additional changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants