Gracefully close connecting channels #2991
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2991 +/- ##
==========================================
- Coverage 77.93% 77.89% -0.04%
==========================================
Files 89 89
Lines 10546 10550 +4
==========================================
- Hits 8219 8218 -1
- Misses 1838 1841 +3
- Partials 489 491 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joeturki
force-pushed
the
fix/close-connecting-channels
branch
2 times, most recently
from
4e15fac to
7870657
Compare
joeturki
force-pushed
the
fix/close-connecting-channels
branch
from
7870657 to
d3b26cb
Compare
joeturki
force-pushed
the
fix/close-connecting-channels
branch
from
d3b26cb to
f647518
Compare
datachannel.go
Outdated
| d.mu.Unlock() | ||
| dc.Close() // nolint:errcheck,gosec |
There was a problem hiding this comment.
I think a comment is required here, since it's not immediately obvious why that is needed.
There was a problem hiding this comment.
I am fixing and merging that right now actually! I am going to log the error.
Also going to get involved with RTX, sorry I have been busy.
There was a problem hiding this comment.
No worries, I'm going to implement TWCC, and come back to RTX when you guys are ready.
There was a problem hiding this comment.
I used to log the error but I removed it in another commit my bad :)
Sean-Der
force-pushed
the
fix/close-connecting-channels
branch
from
f647518 to
032e3eb
Compare
Fixes an issue where calling dataChannel.Close on 'connecting' state channels didn't work as expected. When handling the `OnOpen` event detect if the user has requested close. Fixes #2659
Sean-Der
force-pushed
the
fix/close-connecting-channels
branch
from
032e3eb to
275ed7b
Compare
Description
This PR fixes an issue where calling
dataChannel.Closeon 'connecting' state channels didn't work as expected; It adds the ability to reject data channels directly from theOnDataConnectionhandler.Reference issue
Fixes #2659