Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of ConfigureTWCCSender #2997

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jech
Copy link
Member

@jech jech commented Jan 8, 2025

Mention that is must be called after registering codecs.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (1ee0299) to head (d33b83d).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2997      +/-   ##
==========================================
+ Coverage   77.93%   79.44%   +1.51%     
==========================================
  Files          89       78      -11     
  Lines       10546     9649     -897     
==========================================
- Hits         8219     7666     -553     
+ Misses       1838     1536     -302     
+ Partials      489      447      -42     
Flag Coverage Δ
go 79.44% <ø> (-0.07%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mention that it must be called after registering codecs.
@jech jech force-pushed the configure-twcc-sender-doc branch from 2962c21 to d33b83d Compare January 8, 2025 14:36
@Sean-Der Sean-Der merged commit c50ca41 into pion:master Jan 8, 2025
17 checks passed
@jech jech deleted the configure-twcc-sender-doc branch January 8, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants