Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite VP8 isKeyFrame check #2999

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Rewrite VP8 isKeyFrame check #2999

merged 1 commit into from
Jan 12, 2025

Conversation

xdrudis
Copy link
Member

@xdrudis xdrudis commented Jan 11, 2025

Description

RFC 6386 describes the least significant bit of the first byte of the header as:

A 1-bit frame type (0 for key frames, 1 for interframes).

The change is functionally a no-op, but the naming implies the wrong logic (you would assume isKeyFrame == 1 means it is a key frame, but the opposite is true).

Reference issue

Fixes #...

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (5edce95) to head (6379b9e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2999   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files          89       89           
  Lines       10578    10578           
=======================================
  Hits         8251     8251           
  Misses       1837     1837           
  Partials      490      490           
Flag Coverage Δ
go 79.57% <100.00%> (ø)
wasm 63.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Sean-Der Sean-Der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

you are really looking into the details!

@xdrudis xdrudis merged commit cdacd1c into pion:master Jan 12, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants