Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix help for Cobra commands #230

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Fix help for Cobra commands #230

merged 1 commit into from
Jan 9, 2025

Conversation

pjcdawkins
Copy link
Contributor

Extracted from #226

  • Cobra-defined commands (probably) have no (useful) legacy CLI help, so we print their usage string from Cobra
  • The help function was shadowing the root command via the 'cmd' variable name

It'd be nice not to use os.Args, but this works

* The help function was shadowing the root command via 'cmd'
* Cobra-defined commands probably have no legacy CLI help so we print their
  usage string
@pjcdawkins pjcdawkins mentioned this pull request Jan 6, 2025
3 tasks
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit b4b4d22 into main Jan 9, 2025
1 check passed
@akalipetis akalipetis deleted the fix-help branch January 9, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants