Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use pion/transport/v3 #480

Closed
wants to merge 1 commit into from

Conversation

hasheddan
Copy link
Contributor

Updates to the newly released pion/transport/v3, which matches the dependency of the pion/dtls version used in this repository.

See pion/transport#264 for more information.

Closes #478

Updates to the newly released pion/transport/v3, which matches the
dependency of the pion/dtls version used in this repository.

Signed-off-by: Daniel Mangum <[email protected]>
@Danielius1922
Copy link
Member

@jkralik It doesn't seem we will be able to merge this until we drop support for go1.18 in plgd/device and plgd/hub, I've tried updating plgd/device to this version of go-coap and it failed compilation with go1.18 (https://github.com/plgd-dev/device/actions/runs/6077781553/job/16488029912?pr=381)

Though it's just a single file (dtlslistener.go) that was modified and the updated pion/transport/udp package is used on 3 lines, so creating and maintaining a go1.18 version of that code (which will be deleted once we drop go1.18 support) won't be hard.

Copy link
Contributor Author

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danielius1922 there has been a patch release in pion/transport to address this issue: https://github.com/pion/transport/releases/tag/v3.0.1

I'll make a similar update in pion/dtls, which is where the dtlslistener atomic.Bool is used.

@hasheddan
Copy link
Contributor Author

Closing in favor of #481

@hasheddan hasheddan closed this Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants