fix(questionregex,questionrange): remove bad FK rows

install/upgrade_to_2.13.php

@@ -319,6 +319,12 @@ public function addDefaultFormListMode() {
       $this->migration->addPostQuery("UPDATE `glpi_plugin_formcreator_entityconfigs` SET `default_form_list_mode`=0 WHERE `entities_id`=0");
    }
 
+   /**
+    * It is possible to have inconsistencies in DB where several identical parameters exist for a single question
+    * Removing all duplicates, and add unicity in the tables
+    *
+    * @return void
+    */
    public function questionParameterUnicity() {
       global $DB;
 
@@ -373,17 +379,25 @@ public function questionParameterUnicity() {
             WHERE dr.plugin_formcreator_questions_id = j.question_id AND dr.id <> j.qrid
       ");
 
-
       $tables = [
          'glpi_plugin_formcreator_questionranges',
          'glpi_plugin_formcreator_questionregexes',
       ];
 
       foreach ($tables as $table) {
+         $DB->delete($table, [
+            'plugin_formcreator_questions_id' => '0'
+         ]);
          $this->migration->addKey($table, ['plugin_formcreator_questions_id', 'fieldname'], 'unicity', 'UNIQUE');
       }
    }
 
+   /**
+    * It is possible to have questions using parameters, but none exist in the DB
+    * ading empty parameters where needed
+    *
+    * @return void
+    */
    public function questionParameterRepair() {
       global $DB;