Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FormcreatorIssues requester not updated #3560

Open
wants to merge 2 commits into
base: support/2.13.0
Choose a base branch
from

Conversation

RomainLvr
Copy link

Changes description

When the requester of a ticket is changed to a new requester, the original writer continues to see the ticket in the simplified and extended service catalog interface.
When the Simplified/Extended Service Catalog is changed to GLPI Support, the original ticket writer no longer sees the ticket.

This is due to the requester in the glpi_plugin_formcreator_issues table not being updated when the ticket's actors are updated, as the hook on Ticket_User is not triggered.

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

References

It fixes !35730

@RomainLvr RomainLvr requested a review from btry January 14, 2025 12:44
@RomainLvr RomainLvr self-assigned this Jan 14, 2025
@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B January 14, 2025 12:44
Copy link
Collaborator

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomainLvr
Copy link
Author

do I provide the patch to the customer for validation?

@btry
Copy link
Collaborator

btry commented Jan 14, 2025

@RomainLvr I usually validate patches with bug reporter then merge once the fix is approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants