fix macos build

- enable macos-latest on github CI
pmed · Jan 7, 2025 · 97c7c28 · 97c7c28
1 parent 2e5e3d0
commit 97c7c28
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -4,17 +4,17 @@ jobs:
   build:
     strategy:
       matrix:
-        os: [ ubuntu-latest, windows-latest ] # macos-latest, 
+        os: [ ubuntu-latest, macos-latest, windows-latest ]
         build_type: [ Release ]
         shared_lib: [ false, true ]
         header_only: [ false, true ]
         include:
           - os: ubuntu-latest
             v8_compress_pointers: false
             v8_enable_sandbox: false
-          #- os: macos-latest
-          #  v8_compress_pointers: true
-          #  v8_enable_sandbox: true
+          - os: macos-latest
+            v8_compress_pointers: true
+            v8_enable_sandbox: true
           - os: windows-latest
             v8_compress_pointers: true
             v8_enable_sandbox: true

diff --git a/v8pp/CMakeLists.txt b/v8pp/CMakeLists.txt
@@ -89,11 +89,6 @@ else()
 	if(BUILD_SHARED_LIBS)
 		target_link_libraries(v8pp PUBLIC ${CMAKE_DL_LIBS})
 	endif()
-	if(APPLE)
-		# turn off RTTI to avoid generating typeinfo for v8::ArrayBuffer::Allocator
-		# used in context.cpp
-		set_source_files_properties(context.cpp PROPERTIES COMPILE_FLAGS -fno-rtti)
-	endif()
 endif()
 
 #source_group(TREE ${CMAKE_CURRENT_SOURCE_DIR} FILES ${V8PP_HEADERS} ${V8PP_SOURCES})