-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] chore: replace forwardRef with props.ref #3282
[v9] chore: replace forwardRef with props.ref #3282
Conversation
|
||
React.useImperativeHandle(ref, () => props) | ||
// React.useImperativeHandle(ref, () => props) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk what to do with this? It didn't work before either
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 36a6774:
|
36a6774
to
0ad0a22
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8abd59d:
|
Hey @alexandernanberg 👋 Do you know if this could cause problems with |
0ad0a22
to
7a76b8c
Compare
@borisghidaglia No, this is not included in the v9 release atm. And I see no reason to why it would affect extend |
Yes I know it's not included! And about why it might affect In theory I believe removing |
I missed this PR, but the changes are indeed unrelated. You likely have a broken build or duplicated installs of R3F itself. We're working on getting RC channels of libraries out (chiefly R3F and Drei), and then we'll start rolling them out to stable. That should make things easier for your package manager as well as testing. |
Thanks for the answer @CodyJasonBennett. I'm actually using My goal was to get @react-three-csg ready for when R3F will be rolled out as stable. I'm going to try to update Drei to the RC channel and see if it solves the problem I'm having with |
https://react.dev/blog/2024/04/25/react-19#ref-as-a-prop