Fixed build_database when config has a space and hyphen #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where config has a space in it (e.g. "Blarg - Debug"), the
output folder would also have a space in it. This broke
build_database_args and build_database_single so iccarm.exe would get
called with malformed arguments:
[..., "-D", "Whatever I have defined", "-no-cse", ...] instead of
[..., "-D", "Whatever I have defined", "--no-cse", ...]
The fix was to change the regex used in build_database args to require
a non-space character after the "-" since iccarm doesn't seem to
support "-" as an arg to indicate to read from stdin.
Also, the new regex doesn't require whitespace before the path, so no
fixup is required afterward to handle the first arg.
Additionally, arg_replacer has been replaced with a simple constant
string.