Add client side check of withdraw-ability #1546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -199,6 +199,14 @@ impl<'config, E: From<TransactionValidationError>> CheckEvmTransaction<'config, | |||
| } | |||
| } | |||
|
|
|||
| pub fn max_withdraw_amount(&self) -> Result<U256, E> { | |||
There was a problem hiding this comment.
Does with_balance_for in CheckEvmTransaction meet your needs?
|
|
||
| use pallet_evm::OnChargeEVMTransaction; | ||
| let max_withdraw = check_transaction.max_withdraw_amount().map_err(|e| e.0)?; | ||
| <T as pallet_evm::Config>::OnChargeTransaction::can_withdraw(&origin, max_withdraw) |
There was a problem hiding this comment.
What additional validation does this offer compared to the with_balance_for mentioned above?
There was a problem hiding this comment.
I'm rechecking this change we have at Moonbeam's frontier fork to see if the issue was fixed with paritytech/polkadot-sdk#2292. Basically it meant to make a consistent check for the withdraw amount to prevent a corner case where the TX would be included in the pool even if it did not have enough balance to pay the fees.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
frame/ethereumandframe/evmmodules to improve transaction validation and add a new method for checking the maximum withdrawable amount on the client side.