Support for non-UTF8 message signature #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for non-UTF8 messages (aka raw messages).
Changes and tests are in separate commits for ease of review.
Building on top of LedgerHQ#13
Thanks @vldmkr for the amazing rundown provided here.
Bonus fix:
Next steps:
In the future, we can do some work to enable displaying longer messages.
One simple option would be, if the signing message is very long, we can compute the signature ahead of time, so that the memory used to store the signing message can be freed and use for formatting.