chore: ロボットタイプの自動設定 #788
Open
chore: ロボットタイプの自動設定 #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kcmsx with
|
| Latest commit: |
4e92647
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a365dca.kcmsx.pages.dev |
| Branch Preview URL: | https://chore-706-auto-select-robott.kcmsx.pages.dev |
GaTo-Rfc
requested review from
laminne,
speak-mentaiko,
kiharu3112 and
tufusa
tufusa
requested changes
Dec 9, 2024
Comment on lines
+18
to
+24
| // カテゴリーが変更されたとき、ロボットタイプが自明な場合は自動で設定する | ||
| useEffect(() => { | ||
| if (config.department[category].robotTypes.length === 1) { | ||
| setRobotType(config.department[category].robotTypes[0]); | ||
| } | ||
| }, [category]); | ||
|
|
There was a problem hiding this comment.
useEffectは、避けられる場合は避けるべきフックです(詳細はReactのドキュメントを参照してください)。この場合L103にこれらの処理を足せば済むので、そうしてください。- これだと、変えた後に2つ以上の選択肢があると何も選ばれていない状態になってしまいます。「変えたカテゴリの
robotTypesに今のrobotTypeがあるか見て、なければ許可されるもののうちの0番目をsetする」のような感じはどうでしょうか？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #706
category変更時、robotTypesのlengthが1であれば自動で選択するように関数を追加。