Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting country names to iso standard #230

Merged
merged 15 commits into from
Jan 2, 2025

Conversation

Kavlahkaff
Copy link
Contributor

@Kavlahkaff Kavlahkaff commented Dec 17, 2024

PR Checklist for modifying one or multiple existing packages

  • The changes maintain the structural integrity of the affected packages.
  • The checksums of the modified files in the respective POSEIDON.yml files were adjusted properly.
  • Every file in the submission is correctly referenced in the relevant POSEIDON.yml files and there are no additional, supplementary files in the submission that are not documented there.

  • The packageVersion numbers of the affected packages were increased in their POSEIDON.yml files.
  • The changes in the packageVersion followed the Poseidon Package versioning policy.
  • The changes were documented in the respective CHANGELOG files. If no CHANGELOG files existed previously it was added here.
  • The lastModified fields of the affected POSEIDON.yml files were updated.
  • The contributor fields were updated with name, email and orcid of the relevant, new contributors.
  • The .janno and the .ssf files are not fully quoted, so they only use single- or double quotes ("...", '...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).

  • All affected packages pass a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@Kavlahkaff
Copy link
Contributor Author

I have now moved this PR to a branch in this repository, not from a fork. I ran trident rectify again to make all the changes necessary in the Poseidon.yml and changelog.md. I did not add myself as a contributor as my changes are very small. Should I delete the original PR?

@nevrome
Copy link
Member

nevrome commented Dec 18, 2024

Thanks! #229 can indeed be deleted, if you have the same changes here now.

I looked through the PR and found it mostly OK. There is only one issue: 2024_Allentoft_PostGlacial_WestEurasia got a CHANGELOG file and an updated POSEIDON.yml file, but the .janno file of this package does not actually feature any changes.

@Kavlahkaff
Copy link
Contributor Author

Oh, yes good catch! I have removed the changelog and reverted the Poseidon.yml

Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I also made some checks and find it OK. Thanks.

@nevrome
Copy link
Member

nevrome commented Jan 2, 2025

OK - if we are all happy with these changes we can merge them. I'll do it now.

@nevrome nevrome merged commit d27e414 into master Jan 2, 2025
1 check passed
@nevrome nevrome deleted the converting_country_names_to_ISO_standard branch January 2, 2025 11:14
@nevrome nevrome restored the converting_country_names_to_ISO_standard branch January 2, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants