-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converting country names to iso standard #230
Conversation
…lumn, made file naming consistent
…sNatureCommunications
…oNatureCommunications
I have now moved this PR to a branch in this repository, not from a fork. I ran trident rectify again to make all the changes necessary in the Poseidon.yml and changelog.md. I did not add myself as a contributor as my changes are very small. Should I delete the original PR? |
Thanks! #229 can indeed be deleted, if you have the same changes here now. I looked through the PR and found it mostly OK. There is only one issue: |
Oh, yes good catch! I have removed the changelog and reverted the Poseidon.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I also made some checks and find it OK. Thanks.
OK - if we are all happy with these changes we can merge them. I'll do it now. |
PR Checklist for modifying one or multiple existing packages
POSEIDON.yml
files were adjusted properly.POSEIDON.yml
files and there are no additional, supplementary files in the submission that are not documented there.packageVersion
numbers of the affected packages were increased in theirPOSEIDON.yml
files.packageVersion
followed the Poseidon Package versioning policy.CHANGELOG
files. If noCHANGELOG
files existed previously it was added here.lastModified
fields of the affectedPOSEIDON.yml
files were updated.contributor
fields were updated withname
,email
andorcid
of the relevant, new contributors..janno
and the.ssf
files are not fully quoted, so they only use single- or double quotes ("..."
,'...'
) to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).