Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove curves sanitizer #421

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove curves sanitizer #421

wants to merge 4 commits into from

Conversation

Lisrte
Copy link
Contributor

@Lisrte Lisrte commented Jan 17, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Use DynawoSimulationHandler::sanitizeDoubleTimeSeries method to handle duplicate times in curves

What is the new behavior (if this is a feature change)?
Remove sanitizeDoubleTimeSeries method and use core PR 3243 with TimeSeriesCsvConfig::skipDuplicateTimeEntry instead.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@Lisrte Lisrte force-pushed the remove_curves_sanitizer branch from 7d443a9 to 1eca8c1 Compare January 17, 2025 16:04
Signed-off-by: lisrte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant