Sbatch options #18
Draft
Sbatch options #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The after() would still be executed if future is cancelled by computation manager(ex: error detected).In this case, it will throw CompleteException. Fix tests: junit assert on main thread. Job id's relation should not be cleared before send scancel cmd to slurm Signed-off-by: Yichen TANG <[email protected]>
Signed-off-by: Yichen TANG <[email protected]>
Signed-off-by: yichen88 <[email protected]>
- Remove --array=0 if count = 1(Not used in previous) - Initialize SbatchGenerator with all parameters(flagdirs, command, workingDir, env) - mydone_ flag file would be added at the last command's execution. If it is not an array job, then just one mydone_ file would be created and the countDownLatch is set to one. If is an array-job, countdownLatch set to n and wait for n mydone_ file created. - Job would be auto cancelled by slurm with a new argument(--kill-on-invalid-dep=yes) added in sbatch's cmd by default. - no more batchIds in TaskStore. Signed-off-by: Yichen TANG <[email protected]>
Signed-off-by: Yichen TANG <[email protected]>
Signed-off-by: Yichen TANG <[email protected]>
Signed-off-by: yichen88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements (please use
'[x]'to check the checkboxes, or submit the PR and then click the checkboxes)Does this PR already have an issue describing the problem ? If so, link to this issue using
'#XXX'and skip the rest#15
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API? If yes, check the following:
Other information:
(if any of the questions/checkboxes don't apply, please delete them entirely)