Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical editor #204

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cesar-luis-galli
Copy link

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

@jonenst
Copy link
Contributor

jonenst commented Nov 4, 2019

Hi,
thanks for contributing to powsybl !
Can you tell us more about this project ?

I launched it and imported the sample src/main/resources/sample/sampleNet.xml

Capture d’écran de 2019-11-04 11-28-39

What are we supposed to do ? I couldn't do anything more than drag elements from the substation.

Cheers,
Jon

@cesar-luis-galli
Copy link
Author

cesar-luis-galli commented Nov 4, 2019 via email

@annetill annetill requested review from jonenst, massimo-ferraro and pl-buiquang and removed request for jonenst November 5, 2019 09:27
@miovd miovd requested a review from geofjamg November 5, 2019 16:50
@jonenst
Copy link
Contributor

jonenst commented Nov 15, 2019

Thanks for taking the time to explain. A good way to make a tutorial is to make a short gif and post it to this issue. I use simplescreenrecorder to record my desktop and then ffmpeg to convert it to a gif ( $ ffmpeg -i foo.mkv foo.gif ) (you can also speed it up and scale it down with $ ffmpeg -i foo.mkv -vf "select='not(mod(n,2))',setpts=N/30/TB,scale=800x600" foo.gif ) (use a different number than 2 for higher speedups). For example, you get this

powsybl_editor

I managed to do everything you described, except adding nodes.. When I create a substation from scratch, I create the busbar in the voltage level, and then I create a disconnector on this busbar but the second terminal of this disconnector should be a node (so that I can attach for example a switch), but I can't find a way to do that, I have the select another node of the substation and there is only the busbar.

Cheers,
Jon

@cesar-luis-galli
Copy link
Author

cesar-luis-galli commented Nov 15, 2019 via email

@cesar-luis-galli
Copy link
Author

cesar-luis-galli commented Nov 17, 2019 via email

@jonenst
Copy link
Contributor

jonenst commented Nov 18, 2019

Hi Cesar,
I can't see the files. Try sending them directly to me instead of github by email, or upload them to a free video hosting service ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants