review

revert disabled add

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/AliasesIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractAliasesTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,19 +16,16 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class AliasesIT extends AbstractAliasesTest {
-    @Disabled("network merge not implemented")
+
     @Override
     @Test
     public void mergeFailWhenAliasEqualsToAnAliasOfOtherNetwork() {
         // FIXME network merge not implemented
-        super.mergeFailWhenAliasEqualsToAnAliasOfOtherNetwork();
     }
 
-    @Disabled("network merge not implemented")
     @Override
     @Test
     public void mergeFailWhenAliasEqualsToAnIdOfOtherNetwork() {
         // FIXME network merge not implemented
-        super.mergeFailWhenAliasEqualsToAnIdOfOtherNetwork();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/BatteryIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractBatteryTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,19 +16,16 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class BatteryIT extends AbstractBatteryTest {
-    @Disabled("exception message aren't homogenized with the powsybl-core")
+
     @Test
     @Override
     public void testRemove() {
         // FIXME remove this test when exception msg are homogenized with the powsybl-core
-        super.testRemove();
     }
 
-    @Disabled("primary key constraints violation on DB")
     @Override
     @Test
     public void testSetterGetterInMultiVariants() {
         //FIXME remove when we fix primary key constraints violation on DB
-        super.testSetterGetterInMultiVariants();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/BusBreakerIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractBusBreakerTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class BusBreakerIT extends AbstractBusBreakerTest {
-    @Disabled("missing reason")
+
     @Test
     @Override
     public void testDisconnectConnect() {
         // FIXME
-        super.testDisconnectConnect();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/CurrentLimitsIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractCurrentLimitsTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,51 +16,40 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class CurrentLimitsIT extends AbstractCurrentLimitsTest {
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
+
     @Override
     @Test
     public void test() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.test();
     }
 
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
     @Override
     @Test
     public void testForThreeWindingsTransformerLeg1() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.testForThreeWindingsTransformerLeg1();
     }
 
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
     @Override
     @Test
     public void testForThreeWindingsTransformerLeg2() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.testForThreeWindingsTransformerLeg2();
     }
 
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
     @Override
     @Test
     public void testForThreeWindingsTransformerLeg3() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.testForThreeWindingsTransformerLeg3();
     }
 
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
     @Override
     @Test
     public void testLimitWithoutTempLimit() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.testLimitWithoutTempLimit();
     }
 
-    @Disabled("Bus.getV/setV not getting/updating correctly the V in all views")
     @Override
     @Test
     public void testSetterGetter() {
         // FIXME delete this test when we fix Bus.getV/setV not getting/updating correctly the V in all views
-        super.testSetterGetter();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/DanglingLineIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractDanglingLineTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class DanglingLineIT extends AbstractDanglingLineTest {
-    @Disabled("primary key constraints violation on DB")
+
     @Override
     @Test
     public void testSetterGetterInMultiVariants() {
         //FIXME remove when we fix primary key constraints violation on DB
-        super.testSetterGetterInMultiVariants();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/ExceptionIsThrownWhenRemoveVariantAndWorkingVariantIsNotSetIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractExceptionIsThrownWhenRemoveVariantAndWorkingVariantIsNotSetTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class ExceptionIsThrownWhenRemoveVariantAndWorkingVariantIsNotSetIT extends AbstractExceptionIsThrownWhenRemoveVariantAndWorkingVariantIsNotSetTest {
-    @Disabled("multi-thread access isn't supported")
+
     @Override
     @Test
     public void test() throws InterruptedException {
         // FIXME delete this test when multi-thread access is supported
-        super.test();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/GeneratorIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractGeneratorTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,19 +16,16 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class GeneratorIT extends AbstractGeneratorTest {
-    @Disabled("exception message aren't homogenized with the powsybl-core")
+
     @Override
     @Test
     public void testRemove() {
         // FIXME remove this test when exception msg are homogenized with the powsybl-core
-        super.testRemove();
     }
 
-    @Disabled("primary key constraints violation on DB")
     @Override
     @Test
     public void testSetterGetterInMultiVariants() {
         //FIXME remove when we fix primary key constraints violation on DB
-        super.testSetterGetterInMultiVariants();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/GroundIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractGroundTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -21,11 +20,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class GroundIT extends AbstractGroundTest {
-    @Disabled("subnetworks aren't implemented")
+
     @Override
     @Test
     public void testOnSubnetwork() {
         // FIXME remove this test when subnetworks are implemented
-        super.testOnSubnetwork();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/HvdcLineIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractHvdcLineTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class HvdcLineIT extends AbstractHvdcLineTest {
-    @Disabled("primary key constraints violation on DB")
+
     @Test
     @Override
     public void testSetterGetterInMultiVariants() {
         //FIXME remove when we fix primary key constraints violation on DB
-        super.testSetterGetterInMultiVariants();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/IdentifiableExtensionIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractIdentifiableExtensionTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class IdentifiableExtensionIT extends AbstractIdentifiableExtensionTest {
-    @Disabled("ZipLoadModelAdder isn't implemented")
+
     @Test
     @Override
     public void test() {
         //FIXME remove this test when ZipLoadModelAdder is implemented
-        super.test();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/LccIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractLccTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class LccIT extends AbstractLccTest {
-    @Disabled("waiting the release containing this PR: https://github.com/powsybl/powsybl-core/pull/3015")
+
     @Override
     @Test
     public void testHvdcLineRemove() {
         // FIXME remove this test when we use the release containing this PR : https://github.com/powsybl/powsybl-core/pull/3015
-        super.testHvdcLineRemove();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/LineIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractLineTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,35 +16,28 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class LineIT extends AbstractLineTest {
-    @Disabled("waiting the release containing this PR: https://github.com/powsybl/powsybl-core/pull/3022")
+
     @Test
     @Override
     public void baseAcLineTests() {
         // FIXME remove this test when we use the release containing this PR : https://github.com/powsybl/powsybl-core/pull/3022
-        super.baseAcLineTests();
     }
 
-    @Disabled("exception message aren't homogenized with the powsybl-core")
     @Test
     @Override
     public void testRemoveAcLine() {
         // FIXME remove this test when exception msg are homogenized with the powsybl-core
-        super.testRemoveAcLine();
     }
 
-    @Disabled("powsybl-network-store-server not use powsybl network store 1.18.0")
     @Test
     @Override
     public void testMove1NbNetwork() {
         // TODO : remove this function as soon as powsybl network store server will use powsybl network store 1.18.0 (it will correct this test)
-        super.testMove1NbNetwork();
     }
 
-    @Disabled("powsybl-network-store-server not use powsybl network store 1.18.0")
     @Test
     @Override
     public void testMove2Nb() {
         // TODO : remove this function as soon as powsybl network store server will use powsybl network store 1.18.0 (it will correct this test)
-        super.testMove2Nb();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/LoadIT.java

@@ -11,7 +11,6 @@
 import com.powsybl.iidm.network.tck.AbstractLoadTest;
 import com.powsybl.iidm.network.test.FictitiousSwitchFactory;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -22,12 +21,11 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class LoadIT extends AbstractLoadTest {
-    @Disabled("ZipLoadModelAdder isn't implemented")
+
     @Override
     @Test
     public void testZipLoadModel() {
         //TODO remove this test when ZipLoadModelAdder is implemented
-        super.testZipLoadModel();
     }
 
     @Override
@@ -39,11 +37,9 @@ public void testExponentialLoadModel() {
         assertNull(voltageLevel.newLoad().newExponentialModel().setNp(0.0).setNq(0.0).add());
     }
 
-    @Disabled("primary key constraints violation on DB")
     @Test
     @Override
     public void testSetterGetterInMultiVariants() {
         //FIXME remove when we fix primary key constraints violation on DB
-        super.testSetterGetterInMultiVariants();
     }
 }

network-store-iidm-tck/src/test/java/com/powsybl/network/store/tck/MainConnectedComponentWithSwitchIT.java

@@ -8,7 +8,6 @@
 
 import com.powsybl.iidm.network.tck.AbstractMainConnectedComponentWithSwitchTest;
 import com.powsybl.network.store.server.NetworkStoreApplication;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.test.context.ContextConfiguration;
@@ -17,11 +16,10 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.DEFINED_PORT, properties = {"spring.config.location=classpath:application.yaml"})
 @ContextHierarchy({@ContextConfiguration(classes = {NetworkStoreApplication.class})})
 class MainConnectedComponentWithSwitchIT extends AbstractMainConnectedComponentWithSwitchTest {
-    @Disabled("losing the v of buses / use the right views")
+
     @Test
     @Override
     public void test() {
         // FIXME remove this test when we stop losing the v of buses / use the right views
-        super.test();
     }
 }