Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pb in tck tests for internal connections. #53

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

FranckLecuyer
Copy link
Contributor

@FranckLecuyer FranckLecuyer commented Aug 13, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Test method testTraversalInternalConnections fails in NodeBreakerInternalConnectionsTest class with network-store implementation.
see PR in network-store-client : powsybl/powsybl-network-store#426

What is the new behavior (if this is a feature change)?
Test method testTraversalInternalConnections now succeeds

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@FranckLecuyer
Copy link
Contributor Author

Waiting for next powsybl-network-store release for this PR to be merged ...

Copy link

@FranckLecuyer FranckLecuyer merged commit d22acc0 into main Aug 27, 2024
4 checks passed
@FranckLecuyer FranckLecuyer deleted the fix_tck_tests_pb_with_internal_connections branch August 27, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants