Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database iidm update for fictitiousP0 and Q0 #55

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

dbraquart
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Copy link
Contributor

@FranckLecuyer FranckLecuyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, you can remove the overrided empty method testSetterGetter in BusBreakerIT tck test class ...

pom.xml Outdated
@@ -50,7 +50,7 @@
<properties>
<sirocco.version>1.0</sirocco.version>

<powsybl-ws-dependencies.version>2.12.0</powsybl-ws-dependencies.version>
<powsybl-ws-dependencies.version>2.13.0-SNAPSHOT</powsybl-ws-dependencies.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use only release version in pom.xml ...
Wait for PR : powsybl/powsybl-network-store#430 to be merged and a new release of powsybl-network-store client to be created, and then override the negwork-store client version in the pom.xml ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes!

# Conflicts:
#	network-store-server/src/main/resources/db/changelog/db.changelog-master.yaml
Copy link

@dbraquart dbraquart merged commit e69a232 into main Sep 10, 2024
4 checks passed
@dbraquart dbraquart deleted the dbraquart/add-fictitious-P0-Q0 branch September 10, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants