demo: restore tests of enableLevelOfDetail #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spurious change from e79a67f Signed-off-by: Jon Harper <[email protected]>
flo-dup
reviewed
Jan 14, 2025
massimo-ferraro
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Sorry, my fault for not explaining the change I did in the other PR. The problem is that setting this parameter value to true makes the edge info (e.g. the active power of the lines) disappear in all the demos (e.g. the first example, the Eurostag network, should have the active power shown). It happens only if you set this parameter to true in the last demo example, could it be set in another demo example?
Currently the dynamic css interferes with the other nads in the page, so allow to reload the page with or without it so that we can still test it Signed-off-by: HARPER Jon <[email protected]>
|
flo-dup
approved these changes
Jan 15, 2025
|
added a simple system to reload the page with enablelevelofdetail=true |
massimo-ferraro
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
NO
What kind of change does this PR introduce?
bugfix, restore demo tests
What is the current behavior?
no test for enablelevelofdetail
What is the new behavior (if this is a feature change)?
tests for enablelevelofdetail restored in demo
Does this PR introduce a breaking change or deprecate an API?
Other information:
spurious change from e79a67f