NAD: clone dynamic css rules to fix missing unapplied rules in some cases #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases The status is stored inside the rule object so having a static variable means that if you have 2 nads the rules are not reapplied in the second one. Signed-off-by: HARPER Jon <[email protected]>
|
I want to add a testcase in demo, will do it soon |
EstherDarkish
approved these changes
Jan 15, 2025
|
sBouzols
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status is stored inside the rule object so having a static variable means that if you have 2 nads the rules are not reapplied in the second one.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
bugfix
What is the current behavior?
sometimes dynamic rules are not reapplied
What is the new behavior (if this is a feature change)?
always reapplied
Does this PR introduce a breaking change or deprecate an API?
NO