Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when dragging in a text box while a key is held down #6485

Merged
merged 2 commits into from
Jan 6, 2025

Resolve inspection issue

635ce03
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix crash when dragging in a text box while a key is held down #6485

Resolve inspection issue
635ce03
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Jan 6, 2025 in 0s

25299 passed, 1 failed and 636 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded-Debug.trx 3162✅ 80⚪ 251s
TestResults-Linux-MultiThreaded-Release.trx 3162✅ 80⚪ 236s
TestResults-Linux-SingleThread-Debug.trx 3162✅ 80⚪ 197s
TestResults-Linux-SingleThread-Release.trx 3162✅ 80⚪ 158s
TestResults-macOS-MultiThreaded-Debug.trx 3162✅ 1❌ 79⚪ 737s
TestResults-macOS-SingleThread-Debug.trx 3163✅ 79⚪ 336s
TestResults-Windows-MultiThreaded-Debug.trx 3163✅ 79⚪ 282s
TestResults-Windows-SingleThread-Debug.trx 3163✅ 79⚪ 215s

✅ TestResults-Linux-MultiThreaded-Debug.trx

3242 tests were completed in 251s with 3162 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-MultiThreaded-Release.trx

3242 tests were completed in 236s with 3162 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Debug.trx

3242 tests were completed in 197s with 3162 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Release.trx

3242 tests were completed in 158s with 3162 passed, 0 failed and 80 skipped.

❌ TestResults-macOS-MultiThreaded-Debug.trx

3242 tests were completed in 737s with 3162 passed, 1 failed and 79 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper 4✅ 1❌ 4s

❌ osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper

✅ TestConstructor
✅ TestManyChildren(False)
✅ TestManyChildren(True)
✅ TestManyChildrenFunction(False)
❌ TestManyChildrenFunction(True)
	not too many loaded

✅ TestResults-macOS-SingleThread-Debug.trx

3242 tests were completed in 336s with 3163 passed, 0 failed and 79 skipped.

✅ TestResults-Windows-MultiThreaded-Debug.trx

3242 tests were completed in 282s with 3163 passed, 0 failed and 79 skipped.

✅ TestResults-Windows-SingleThread-Debug.trx

3242 tests were completed in 215s with 3163 passed, 0 failed and 79 skipped.

Annotations

Check failure on line 0 in TestResults-macOS-MultiThreaded-Debug.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper ► TestManyChildrenFunction(True)

Failed test found in:
  TestResults-macOS-MultiThreaded-Debug.trx
Error:
  not too many loaded
Raw output
not too many loaded
   at osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper.TestManyChildrenFunction(Boolean instant) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Visual/Drawables/TestSceneDelayedLoadWrapper.cs:line 146
   at InvokeStub_TestSceneDelayedLoadWrapper.TestManyChildrenFunction(Object, Span`1)